-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TEAL 4 basic ops #67
Conversation
@jdtzmn does |
Yes, I think that makes sense. @jannotti any thoughts? |
I'm ambivalent - I don't like that it implies the g is for "generated", as we're going for "group", as with gload and gtxn. But I guess you won't need the g's because it is known from context in pyteal? How will gload appear? Does the g in gtxn show up in pyteal naming? I do like 'generated' compared to 'created' for being when clearer that it's about the ID that was made in that transaction. So... I think it's good if you feel it fits in well with other choices in pyteal. I don't know it all that well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I like the overloads.
@jannotti And yes g does show up in the |
Closes #65. |
This PR adds support for the following feature from TEAL v4:
extra_program_pages
transaction fieldGeneratedID
expressionBitLen
expressionSqrt
expressionShiftLeft
,ShiftRight
, andExp
expressions