Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ops for Byteslice arithmetic #75

Merged
merged 7 commits into from
Jul 15, 2021
Merged

Add ops for Byteslice arithmetic #75

merged 7 commits into from
Jul 15, 2021

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Jul 14, 2021 •
edited

This commit adds support for Byteslice arithmetic operations (e.g. b+, b~, etc.) that were introduced in Teal V4 (#73).

  • Adds byteslice arithmetic operations (see Algorand Opcodes)
  • Updates documentation for byteslice arithmetic operations
  • Add a line to README.md for installing requirements.txt

Closes #73

algochoi
algochoi commented Jul 14, 2021
View reviewed changes
pyteal/ast/binaryexpr.py Outdated Show resolved Hide resolved
jasonpaulos
jasonpaulos requested changes Jul 14, 2021
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and tests look good! I left some suggestions for docs improvements.

README.md Outdated Show resolved Hide resolved
pyteal/ast/binaryexpr.py Outdated Show resolved Hide resolved
pyteal/ast/binaryexpr.py Outdated Show resolved Hide resolved
pyteal/ast/binaryexpr.py Outdated Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
docs/arithmetic_expression.rst Outdated Show resolved Hide resolved
docs/arithmetic_expression.rst Show resolved Hide resolved
jasonpaulos
jasonpaulos requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments about the docs table, otherwise this looks good!

docs/arithmetic_expression.rst Outdated Show resolved Hide resolved
docs/arithmetic_expression.rst Outdated Show resolved Hide resolved
jasonpaulos
jasonpaulos requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last change request I promise 😄

docs/arithmetic_expression.rst Outdated Show resolved Hide resolved
docs/arithmetic_expression.rst Show resolved Hide resolved
jasonpaulos
jasonpaulos approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to squash + merge this and delete your branch

@algochoi algochoi merged commit 3049d8e into master Jul 15, 2021
@algochoi algochoi deleted the algochoi/add-binary-mathops branch July 15, 2021 22:31
@jasonpaulos jasonpaulos mentioned this pull request Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support byteslice math
2 participants
@algochoi @jasonpaulos