Add C# implemenation for 1D Convolutions

[stormofice]

Requires .NET 5.0 [SDK Install instructions]

If you want to test this implementation on your machine, create a file in the code/csharp directory called code.csproj and paste the following into it:

<Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
        <OutputType>Exe</OutputType>
        <TargetFramework>net5.0</TargetFramework>
    </PropertyGroup>

</Project>

Now you can execute dotnet run to run the implementation.

[ntindle]

[lang: c#]

[Trashtalk217]

I've attempted to check your code, but I haven't been able to run it yet. C# environments are a whole thing.

I've been able to check the website build, and there's still quite a lot to do there:

This is showing up in the Julia implementation and I have no clue why it is there.

If you need help with setting up honkit, please let me know.

[Trashtalk217]

I'll do a code review later, since I don't have much time:

The line numbers in the .md file are off for the Julia imports, make sure that looks good.
You've got an off by one error in your .dat files:

Here are the files generated by the Julia implementation for reference:
cyclic.txt
full_linear.txt
simple_linear.txt

Don't forget that Julia starts indexing at 1 for arrays and not 0.

[stormofice]

Thanks for the review, I fixed the errors you described above and it now produces the following output [which seems to be correct]:
cyclic.txt

[Trashtalk217]

The off-by-one error I noted for the cyclic convolution also exists in the other two convolutions.
Also, for the full-linear implementation, Julia generates an output file of 399 lines and you generate 400 lines. I'm guessing that that's a bug in the Julia implementation, however.

[stormofice]

Thanks for the review, I forgot about the linear convolutions.

The errors should be fixed now; the full linear output includes a 0.0 at the end which the julia implementation does not, however if you print out the value at full_linear_output[output_size] (so the last value in the array) in the julia implementation, it also shows 0.0 and it just does not get written to file (that's my assumption at least).

The following outputs get produced:
full_linear.txt
simple_linear.txt

[jiegillet]

The line missing is probably because we did a ninja edit on the Julia code here: #854. Before that, there was a 0.0 at the end.
The right number of lines is definitely 399.

[stormofice]

Oh it's the same PR that caused the problem with the Julia line numbers, I'll copy those changes then into the C# implementation.

[stormofice]

@Trashtalk217 I think that all the aforementioned problems should be fixed now, if you want to take another look at this.

[Trashtalk217]

Of all things that don't matter, this review matters very little. I checked the build - looks good, and the output - also looks good. There's some minor picking at the comments but it looks great otherwise.

(I also used suggestions so you don't have to go into your editor again, I don't want to waste your time by havng you place periods.)

[stormofice]

Should all be fixed now, thanks for the review.