Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy some docs #13

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Deploy some docs #13

merged 5 commits into from
Oct 23, 2020

Conversation

ali-ramadhan
Copy link
Owner

Gonna try adding some docs to help get people started.

Also very helpful to have push_preview=true to help debug/look at output when working on adding new features like #11.

Resolves #10

Copy link
Collaborator

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It might be nice in the future to use GHA to push previews so that we can easily find the link to the previews. It took me a minute to find the link.

@ali-ramadhan
Copy link
Owner Author

Ah didn't know GHA made push previews much easier to access. Will open an issue about that!

@ali-ramadhan ali-ramadhan merged commit ee71187 into master Oct 23, 2020
@ali-ramadhan ali-ramadhan deleted the ar/deploy-docs branch October 23, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some documentation
2 participants