Properly format en and em dashes in reference titles #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a very naive approach that scales as O(B*R) where B is the number of items in the bibliography and R is the number of possible replacements. But maybe we don't expect too many replacements. Certainly there aren't that many text replacements we want to do for titles I think. |
simonbyrne
reviewed
Oct 23, 2020
Comment on lines
+12
to
+15
| for replacement in tex2unicode_replacements | ||
| s = replace(s, replacement) | ||
| end | ||
| return s |
There was a problem hiding this comment.
I think you can use multiple pairs in one replace
Suggested change
| for replacement in tex2unicode_replacements | |
| s = replace(s, replacement) | |
| end | |
| return s | |
| replace(s, tex2unicode_replacements...) |
There was a problem hiding this comment.
Ah looks like
replace(A, old_new::Pair...; [count::Integer])is defined in general but for strings we are stuck with
replace(s::AbstractString, pat=>r; [count::Integer])😞
There was a problem hiding this comment.
Ah, I just realised. Upstream issue JuliaLang/julia#35327
Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
This reverts commit fd865e2.
ali-ramadhan
force-pushed
the
ar/tex-2-unicode
branch
from
e2a3a5f
to
da5cdff
Compare
charleskawczynski
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts adding support for converting common TeX to unicode starting with en and em dashes.
This PR depends on #13.
Resolves #11 (?)