Print error log and trace when provider init failed.

alibaba · Jan 4, 2021 · 5829604 · 5829604
1 parent d60c654
commit 5829604
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/arouter-api/src/main/java/com/alibaba/android/arouter/core/LogisticsCenter.java b/arouter-api/src/main/java/com/alibaba/android/arouter/core/LogisticsCenter.java
@@ -88,7 +88,7 @@ private static void register(String className) {
                             + " should implements one of IRouteRoot/IProviderGroup/IInterceptorGroup.");
                 }
             } catch (Exception e) {
-                logger.error(TAG,"register class error:" + className);
+                logger.error(TAG,"register class error:" + className, e);
             }
         }
     }
@@ -287,7 +287,8 @@ public synchronized static void completion(Postcard postcard) {
                             Warehouse.providers.put(providerMeta, provider);
                             instance = provider;
                         } catch (Exception e) {
-                            throw new HandlerException("Init provider failed! " + e.getMessage());
+                            logger.error(TAG, "Init provider failed!", e);
+                            throw new HandlerException("Init provider failed!");
                         }
                     }
                     postcard.setProvider(instance);

diff --git a/arouter-api/src/main/java/com/alibaba/android/arouter/facade/template/ILogger.java b/arouter-api/src/main/java/com/alibaba/android/arouter/facade/template/ILogger.java
@@ -27,6 +27,8 @@ public interface ILogger {
 
     void error(String tag, String message);
 
+    void error(String tag, String message, Throwable e);
+
     void monitor(String message);
 
     boolean isMonitorMode();

diff --git a/arouter-api/src/main/java/com/alibaba/android/arouter/launcher/_ARouter.java b/arouter-api/src/main/java/com/alibaba/android/arouter/launcher/_ARouter.java
@@ -492,7 +492,7 @@ boolean addRouteGroup(IRouteGroup group) {
 
             return true;
         } catch (Exception exception) {
-            logger.error(Consts.TAG, "Add route group dynamic exception! " + exception.getMessage());
+            logger.error(Consts.TAG, "Add route group dynamic exception!", exception);
         }
 
         return false;

diff --git a/arouter-api/src/main/java/com/alibaba/android/arouter/utils/DefaultLogger.java b/arouter-api/src/main/java/com/alibaba/android/arouter/utils/DefaultLogger.java
@@ -71,6 +71,14 @@ public void error(String tag, String message) {
         }
     }
 
+    @Override
+    public void error(String tag, String message, Throwable e) {
+        if (isShowLog) {
+            Log.e(TextUtils.isEmpty(tag) ? getDefaultTag() : tag, message, e);
+        }
+    }
+
+
     @Override
     public void monitor(String message) {
         if (isShowLog && isMonitorMode()) {