Fixes the misuse of "continue-on-error" and "fail_ci_if_error". (#2904)

See also commit 612bd7f. Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
alibaba · Jun 15, 2023 · 0a44e71 · 0a44e71
1 parent 612bd7f
commit 0a44e71
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/gae.yml b/.github/workflows/gae.yml
@@ -99,6 +99,7 @@ jobs:
 
     - name: Upload Coverage
       uses: codecov/codecov-action@v3
+      continue-on-error: true
       with:
         file: ./python/coverage.xml
-        continue-on-error: true
+        fail_ci_if_error: false
diff --git a/.github/workflows/k8s-ci.yml b/.github/workflows/k8s-ci.yml
@@ -490,9 +490,10 @@ jobs:
 
       - name: Upload Coverage
         uses: codecov/codecov-action@v3
+        continue-on-error: true
         with:
           file: ./python/coverage.xml
-          continue-on-error: true
+          fail_ci_if_error: false
 
       - name: HDFS test
         env:

diff --git a/.github/workflows/local-ci.yml b/.github/workflows/local-ci.yml
@@ -380,9 +380,10 @@ jobs:
     - name: Upload Coverage
       if: ${{ needs.changes.outputs.gae-python == 'true' || github.ref == 'refs/heads/main' }}
       uses: codecov/codecov-action@v3
+      continue-on-error: true
       with:
         file: ./coverage.xml
-        continue-on-error: true
+        fail_ci_if_error: false
 
   networkx-basic-test:
     runs-on: ubuntu-20.04

diff --git a/.github/workflows/networkx-forward-algo-nightly.yml b/.github/workflows/networkx-forward-algo-nightly.yml
@@ -47,6 +47,7 @@ jobs:
 
     - name: Upload Coverage
       uses: codecov/codecov-action@v3
+      continue-on-error: true
       with:
         file: ./python/coverage.xml
-        continue-on-error: true
+        fail_ci_if_error: false
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -71,6 +71,7 @@ jobs:
     - name: Upload Coverage
       uses: codecov/codecov-action@v3
       if: matrix.os == 'ubuntu-20.04'
+      continue-on-error: true
       with:
         file: ./python/coverage.xml
-        continue-on-error: true
+        fail_ci_if_error: false
diff --git a/python/setup.py b/python/setup.py
@@ -228,7 +228,7 @@ def build_learning_engine():
     library_dirs.append(ROOT_PATH + "/graphlearn/built/lib")
 
     extra_compile_args.append("-D__USE_XOPEN2K8")
-    extra_compile_args.append("-std=c++11")
+    extra_compile_args.append("-std=c++17")
     extra_compile_args.append("-fvisibility=hidden")
 
     libraries.append("graphlearn_shared")