Skip to content

Commit

Permalink
fix(interactive): throw unsupported error when query PathExpand() w…
Browse files Browse the repository at this point in the history
…ithin subtask (#3133)

<!--
Thanks for your contribution! please review
https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before
opening an issue.
-->

## What do these changes do?

<!-- Please give a short brief about these changes. -->

Currently, throw unsupported error when query `PathExpand()` (which is
implemented by `Iterate`) within subtask in physical plan in GIE.

Once Pegasus supports `Apply` with `Iterate` in subtask, this can be
removed.

## Related issue number

<!-- Are there any issues opened that will be resolved by merging this
change? -->

#3132
  • Loading branch information
BingqingLyu committed Aug 22, 2023
1 parent d62a8f7 commit aba3c08
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions interactive_engine/executor/ir/core/src/plan/physical.rs
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,17 @@ impl AsPhysical for LogicalPlan {
if let Some(Apply(apply_opr)) = curr_node.borrow().opr.opr.as_ref() {
let mut sub_bldr = PlanBuilder::default();
if let Some(subplan) = self.extract_subplan(curr_node.clone()) {
for (_, node) in &subplan.nodes {
let operator = node.borrow().opr.clone();
match operator.opr.as_ref() {
// TODO(bingqing): remove this when engine supports.
Some(pb::logical_plan::operator::Opr::Path(_)) => {
Err(IrError::Unsupported("PathExpand in Apply".to_string()))?
}
_ => {}
}
}

let mut expand_degree_opt = None;
if subplan.len() <= 2 {
if subplan.len() == 1 {
Expand Down

0 comments on commit aba3c08

Please sign in to comment.