Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): throw unsupported error when query PathExpand() within subtask #3133

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

BingqingLyu
Copy link
Collaborator

What do these changes do?

Currently, throw unsupported error when query PathExpand() (which is implemented by Iterate) within subtask in physical plan in GIE.

Once Pegasus supports Apply with Iterate in subtask, this can be removed.

Related issue number

#3132

@codecov-commenter
Copy link

Codecov Report

Merging #3133 (5a8c02c) into main (2ba0922) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3133   +/-   ##
=======================================
  Coverage   42.63%   42.63%           
=======================================
  Files         100      100           
  Lines       10817    10817           
=======================================
  Hits         4612     4612           
  Misses       6205     6205           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62a8f7...5a8c02c. Read the comment docs.

Copy link
Collaborator

@lnfjpt lnfjpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longbinlai longbinlai merged commit aba3c08 into alibaba:main Aug 22, 2023
29 checks passed
@BingqingLyu BingqingLyu deleted the ir_apply_iter_unsupported branch August 22, 2023 06:18
zhanglei1949 pushed a commit to zhanglei1949/GraphScope that referenced this pull request Aug 22, 2023
…ithin subtask (alibaba#3133)

<!--
Thanks for your contribution! please review
https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before
opening an issue.
-->

## What do these changes do?

<!-- Please give a short brief about these changes. -->

Currently, throw unsupported error when query `PathExpand()` (which is
implemented by `Iterate`) within subtask in physical plan in GIE.

Once Pegasus supports `Apply` with `Iterate` in subtask, this can be
removed.

## Related issue number

<!-- Are there any issues opened that will be resolved by merging this
change? -->

alibaba#3132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants