Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Tinkerpop gremlin test cases in GAIA IR. #1802

Closed
7 of 11 tasks
siyuan0322 opened this issue Jul 6, 2022 · 2 comments · Fixed by #1815, #1847, #1852, #1853 or #1901
Closed
7 of 11 tasks

Support Tinkerpop gremlin test cases in GAIA IR. #1802

siyuan0322 opened this issue Jul 6, 2022 · 2 comments · Fixed by #1815, #1847, #1852, #1853 or #1901
Assignees
@shirly121
Labels
component:gaia GAIA, the preview release of the next version of GIE
Projects
GIE for production (0627-0729) - exte...

Comments

@siyuan0322
Copy link
Collaborator

siyuan0322 commented Jul 6, 2022 •
edited by longbinlai
Loading

We plan to support these test cases in this scrum (0627 - 0715)

  • aggregation, min / max / sum / countDistinct / toList(fold) (to be fixed in ir_compiler_aggFn)
  • mean (avg in ir)
  • hasNot
  • dedup by variables
  • dedup by subtask
  • selecting a none tag should return empty result instead of throwing exception (to be fixed in select_none_tag)
  • cases with unexpected results (range(1,2) with a lower bound greater than 0 is unsupported in runtime)

We plan to support these test cases in the near future

  • and/or operators
  • count(local)/order(local)
  • repeat
  • path, simplePath, cyclicPath

Support for these test cases are not planned

  1. choose
  2. parameters of V() and hasId() are constrained to integer or list of integers in ir grammar, V("1") or hasId("id") will not be supported under this consideration
@shirly121 shirly121 self-assigned this Jul 6, 2022
@shirly121 shirly121 added the component:gaia GAIA, the preview release of the next version of GIE label Jul 6, 2022
@siyuan0322
Copy link
Collaborator Author

Remove the TODO in ci.yml

@BingqingLyu BingqingLyu mentioned this issue Jul 8, 2022
Merged
This was referenced Jul 11, 2022
Merged
Merged
@BingqingLyu BingqingLyu mentioned this issue Jul 19, 2022
Merged
@shirly121 shirly121 mentioned this issue Jul 19, 2022
Merged
This was linked to pull requests Jul 28, 2022
[GAIA-IR] Support sum() in GAIA-Runtime #1815
Merged
[GAIA-IR] support more patterns of aggregate functions, i.e min/max/toList/toSet/avg/countDistinct #1847
Merged
[IR Runtime] support mean() in runtime #1852
Merged
[IR Compiler] support hasNot in ir compiler #1853
Merged
[GAIA-IR] support more patterns of dedup().by() in ir compiler #1901
Merged
@longbinlai
Copy link
Collaborator

Remaining cases such as path/repeat etc may be reopened in a new issue in the next-stage scrum.

GIE for production (0627-0729) - extended for two weeks automation moved this from In progress to Done Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shirly121 shirly121

Labels
component:gaia GAIA, the preview release of the next version of GIE
Projects
No open projects
GIE for production (0627-0729) - exte...
  
Done
Milestone
No milestone
3 participants
@longbinlai @siyuan0322 @shirly121