Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR Compiler] support hasNot in ir compiler #1853

Merged
merged 6 commits into from
Jul 19, 2022
Merged

[IR Compiler] support hasNot in ir compiler #1853

merged 6 commits into from
Jul 19, 2022

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Jul 19, 2022

What do these changes do?

  1. hasNot("age") -> !@.age
  2. lower bound of the limit operator should start from 0, range(1, 2) with a lower bound greater than 0 is unsupported in ir runtime, currently remove traversalMethod_range from the grammar

Related issue number

#1802

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #1853 (8d76db3) into main (2695783) will decrease coverage by 32.87%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1853       +/-   ##
===========================================
- Coverage   72.99%   40.11%   -32.88%     
===========================================
  Files          89       89               
  Lines        9804     9804               
===========================================
- Hits         7156     3933     -3223     
- Misses       2648     5871     +3223     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.30%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.66%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.57%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2695783...8d76db3. Read the comment docs.

@longbinlai longbinlai merged commit 0a8e9c1 into alibaba:main Jul 19, 2022
@longbinlai longbinlai deleted the ir_compiler_hasNot branch July 19, 2022 13:12
@longbinlai longbinlai linked an issue Jul 28, 2022 that may be closed by this pull request
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Tinkerpop gremlin test cases in GAIA IR.
3 participants