Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAIA-IR] support more patterns of aggregate functions, i.e min/max/toList/toSet/avg/countDistinct #1847

Merged
merged 12 commits into from
Jul 28, 2022
Merged

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Jul 15, 2022

What do these changes do?

Related issue number

as titled

#1802

@shirly121 shirly121 changed the title [GAIA-IR] support more patterns of aggregate functions, i.e min/max/fold/sum/mean [GAIA-IR] support more patterns of aggregate functions, i.e min/max/toList/toSet/avg/countDistinct Jul 15, 2022
@shirly121 shirly121 added the wip label Jul 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #1847 (c491f67) into main (6616ee0) will decrease coverage by 3.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
- Coverage   43.81%   40.04%   -3.78%     
==========================================
  Files          89       89              
  Lines        9804     9804              
==========================================
- Hits         4296     3926     -370     
- Misses       5508     5878     +370     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/deploy/hosts/cluster.py 31.64% <0.00%> (-55.70%) ⬇️
python/graphscope/analytical/app/java_app.py 24.24% <0.00%> (-44.95%) ⬇️
python/graphscope/framework/utils.py 40.10% <0.00%> (-14.85%) ⬇️
python/graphscope/framework/app.py 69.95% <0.00%> (-10.33%) ⬇️
python/graphscope/client/rpc.py 81.48% <0.00%> (-8.34%) ⬇️
python/graphscope/framework/graph_schema.py 52.45% <0.00%> (-7.11%) ⬇️
python/graphscope/tests/conftest.py 48.21% <0.00%> (-4.65%) ⬇️
python/graphscope/client/session.py 63.75% <0.00%> (-3.22%) ⬇️
python/graphscope/analytical/udf/utils.py 36.17% <0.00%> (-3.20%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6616ee0...c491f67. Read the comment docs.

@shirly121
Copy link
Collaborator Author

There remains some bugs of group to be fixed:

  1. g.V().group().by(values("name").as("a")).select("a")

image

it seems that values("name") is aliased as "0" in the query g.V().group().by(values("name").as("a"))

image

  1. g.V().group().by(outE().count()).by("name")

image

@BingqingLyu
Copy link
Collaborator

There remains some bugs of group to be fixed:

  1. g.V().group().by(values("name").as("a")).select("a")
image

it seems that values("name") is aliased as "0" in the query g.V().group().by(values("name").as("a"))

image

  1. g.V().group().by(outE().count()).by("name")

image

Related issue #1851

@longbinlai longbinlai merged commit 2ac5213 into alibaba:main Jul 28, 2022
@longbinlai longbinlai deleted the ir_compiler_aggFn branch July 28, 2022 02:07
@longbinlai longbinlai linked an issue Jul 28, 2022 that may be closed by this pull request
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Tinkerpop gremlin test cases in GAIA IR.
4 participants