Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable proxy settings for dataset in values of helm #2512

Closed
YANGBoSunning opened this issue Mar 14, 2023 · 3 comments · Fixed by #2513
Closed

Enable proxy settings for dataset in values of helm #2512

YANGBoSunning opened this issue Mar 14, 2023 · 3 comments · Fixed by #2513

Comments

@YANGBoSunning
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The dataset container of graphscope provides the function of obtaining sample dataset online, but there are many inconveniences in accessing the external network to obtain data in many Intranet environments. Therefore, the option of configuring the proxy service address for the dataset container should be added to the configuration file of helm

Describe the solution you'd like
A clear and concise description of what you want to happen.
In the values file of helm, add the configuration item proxy of dataset.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I provided the corresponding configuration of dataset in the values file of helm, modified the cluster_builder.py coordinator.py kubernetes_launcher.py, and added a dataset_proxy attribute in the corresponding classes

Additional context
Add any other context or screenshots about the feature request here.

@siyuan0322
Copy link
Collaborator

siyuan0322 commented Mar 14, 2023

I provided the corresponding configuration of dataset in the values file of helm, modified the cluster_builder.py coordinator.py kubernetes_launcher.py, and added a dataset_proxy attribute in the corresponding classes

Great! Have you already rolled out a working version? Would you consider to submit a PR to address this?

@YANGBoSunning
Copy link
Contributor Author

please hold on, i will push it some minutes later.

@YANGBoSunning
Copy link
Contributor Author

I'm sorry that we used version 0.19.0 for deployment. We haven't actually deployed the code of main branch yet. Looking forward to your review @siyuan0322

siyuan0322 pushed a commit that referenced this issue Mar 14, 2023
This PR adds an option of configuring the proxy service address for the
dataset container should be added to the configuration file of helm

The dataset container of graphscope provides the function of obtaining
sample dataset online, but there are many inconveniences in accessing
the external network to obtain data in many Intranet environments.

Fixes #2512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants