Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify timeout parameters within coordinator #2734

Closed
siyuan0322 opened this issue May 24, 2023 · 0 comments · Fixed by #2915
Closed

Unify timeout parameters within coordinator #2734

siyuan0322 opened this issue May 24, 2023 · 0 comments · Fixed by #2915
Assignees
@TaoLbr1993
Labels
good first issue Good for newcomers

Comments

@siyuan0322
Copy link
Collaborator

siyuan0322 commented May 24, 2023 •
edited

The Coordinator contains many operations that do not return immediately, but wait for a period of time to succeed or return an error after a timeout.

These operations include but are not limited to:

  • creating Coordinator services (PODs)
  • creating GAE services (PODs)
  • creating GIE services (PODs)
  • creating GLE services (PODs)
  • stopping (deleting) the above services (PODs)
  • and querying results from GIE.

The timeout time in the Coordinator is quite fragmented, and each operation does not use a unified timeout parameter to control, which also makes it difficult to adjust the timeout time of each operation from the client.

It is expected to use one single timeout parameter to control all the waiting timeouts in the Coordinator.
@siyuan0322 siyuan0322 added the good first issue Good for newcomers label May 24, 2023
@TaoLbr1993 TaoLbr1993 self-assigned this Jun 6, 2023
@TaoLbr1993 TaoLbr1993 mentioned this issue Jun 19, 2023
Merged
siyuan0322 pushed a commit that referenced this issue Jul 6, 2023
@TaoLbr1993
Add timeout parameters for coordinations (#2915)
6ade1d5 
Add timeout parameters for coordinations such that they can be tuned via arguments

Fixes #2734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TaoLbr1993 TaoLbr1993

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Coordinator] Fix issue #2734: unifying timeout parameter in coordinators TaoLbr1993/GraphScope
2 participants
@siyuan0322 @TaoLbr1993