Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coordinator] Fix issue #2734: unifying timeout parameter in coordinators #2915

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

TaoLbr1993
Copy link
Collaborator

@TaoLbr1993 TaoLbr1993 commented Jun 19, 2023

What do these changes do?

  1. Add timeout parameters for coordinations such that they can be adjusted via arguments;
  2. Add retry time parameters for coordinations such that they can be adjusted via arguments;
  3. Refine the logic of testing timeout to avoid the unwanted error if timeout is less than retry time;
  4. Correct a typo in a function name.

Related issue number

Fixes #2734

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2023

CLA assistant check
All committers have signed the CLA.

@TaoLbr1993 TaoLbr1993 changed the title A try to fix issue #2734: unifying timeout parameter [WIP] A try to fix issue #2734: unifying timeout parameter Jun 19, 2023
@yecol
Copy link
Collaborator

yecol commented Jun 19, 2023

hi @TaoLbr1993 , to pass the configured checks, you need to sign CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

Merging #2915 (c7d4040) into main (d0dc2b7) will decrease coverage by 7.76%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
- Coverage   73.96%   66.21%   -7.76%     
==========================================
  Files          99       99              
  Lines       10687    10676      -11     
==========================================
- Hits         7905     7069     -836     
- Misses       2782     3607     +825     

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0dc2b7...c7d4040. Read the comment docs.

@TaoLbr1993 TaoLbr1993 changed the title [WIP] A try to fix issue #2734: unifying timeout parameter [Coordinator] A try to fix issue #2734: unifying timeout parameter Jun 20, 2023
@TaoLbr1993 TaoLbr1993 changed the title [Coordinator] A try to fix issue #2734: unifying timeout parameter [Coordinator] Gix issue #2734: unifying timeout parameter in coordinators Jun 20, 2023
@TaoLbr1993 TaoLbr1993 changed the title [Coordinator] Gix issue #2734: unifying timeout parameter in coordinators [Coordinator] Fix issue #2734: unifying timeout parameter in coordinators Jun 20, 2023
@siyuan0322 siyuan0322 merged commit 6ade1d5 into alibaba:main Jul 6, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify timeout parameters within coordinator
5 participants