Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to connect to the existed ETCD cluster in GraphScope #1359

Merged
merged 8 commits into from
Mar 11, 2022

Conversation

wuyueandrew
Copy link
Contributor

@wuyueandrew wuyueandrew commented Mar 8, 2022

What do these changes do?

add new start param etcd_addrs to specify etcd ,such as

     --k8s_etcd_addrs
     "10.106.250.244:2379,"

Related issue number

Fixes #1343

Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks fine, but there should be a parameter in the Session for user to pass the addr.

coordinator/gscoordinator/cluster.py Outdated Show resolved Hide resolved
coordinator/gscoordinator/cluster.py Outdated Show resolved Hide resolved
coordinator/gscoordinator/coordinator.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@lidongze0629 lidongze0629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your pull request, it's a great job!

And I think there are still some work to be done before merged into main branch.

  1. In addition to modifying the parts of k8s, the way launching session locally also needs to be changed. See detail from create etcd locally

  2. And at the same time, you also need to update the code of client to ensure etcd_addrs can be passed to the coordinator, some useful info for you, such as session defination, launch coordinator from client

@lidongze0629 lidongze0629 changed the title Issues1343 20220303 Enable to connect to the existed ETCD cluster in GraphScope (Issues1343 20220303) Mar 8, 2022
@wuyueandrew
Copy link
Contributor Author

thanks, i'll fix these points

@sighingnow sighingnow changed the title Enable to connect to the existed ETCD cluster in GraphScope (Issues1343 20220303) Enable to connect to the existed ETCD cluster in GraphScope Mar 8, 2022
Copy link
Collaborator

@lidongze0629 lidongze0629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1359 (88bdd42) into main (5ea7c0d) will decrease coverage by 1.26%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
- Coverage   73.56%   72.29%   -1.27%     
==========================================
  Files          88       88              
  Lines        9603     9609       +6     
==========================================
- Hits         7064     6947     -117     
- Misses       2539     2662     +123     
Impacted Files Coverage Δ
python/graphscope/client/session.py 74.71% <ø> (ø)
python/graphscope/deploy/kubernetes/cluster.py 76.06% <50.00%> (-0.21%) ⬇️
python/graphscope/deploy/hosts/cluster.py 87.34% <66.66%> (-0.82%) ⬇️
python/graphscope/config.py 100.00% <100.00%> (ø)
python/graphscope/tests/unittest/test_java_app.py 55.00% <0.00%> (-45.00%) ⬇️
python/graphscope/analytical/app/java_app.py 24.24% <0.00%> (-44.95%) ⬇️
python/graphscope/framework/utils.py 64.56% <0.00%> (-1.05%) ⬇️
python/graphscope/framework/app.py 89.44% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea7c0d...88bdd42. Read the comment docs.

@siyuan0322 siyuan0322 merged commit 2c56d49 into alibaba:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each coordinator create its own etcd cluster,how about use unified etcd cluster for all coordinators
5 participants