-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to connect to the existed ETCD cluster in GraphScope #1359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks fine, but there should be a parameter in the Session
for user to pass the addr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting your pull request, it's a great job!
And I think there are still some work to be done before merged into main branch.
-
In addition to modifying the parts of k8s, the way launching session locally also needs to be changed. See detail from create etcd locally
-
And at the same time, you also need to update the code of client to ensure
etcd_addrs
can be passed to the coordinator, some useful info for you, such as session defination, launch coordinator from client
thanks, i'll fix these points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## main #1359 +/- ##
==========================================
- Coverage 73.56% 72.29% -1.27%
==========================================
Files 88 88
Lines 9603 9609 +6
==========================================
- Hits 7064 6947 -117
- Misses 2539 2662 +123
Continue to review full report at Codecov.
|
4484655
to
88bdd42
Compare
What do these changes do?
add new start param etcd_addrs to specify etcd ,such as
Related issue number
Fixes #1343