Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused append-only arrow fragment. #1477

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

The fragment is not unused anymore and we can stop maintianing it when we do some vineyard related refactors.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #1477 (f06e007) into main (daa8649) will decrease coverage by 6.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
- Coverage   73.60%   67.04%   -6.57%     
==========================================
  Files          88       88              
  Lines        9719     9719              
==========================================
- Hits         7154     6516     -638     
- Misses       2565     3203     +638     
Impacted Files Coverage Δ
...aphscope/tests/kubernetes/test_resource_builder.py 0.00% <0.00%> (-100.00%) ⬇️
...on/graphscope/tests/kubernetes/test_demo_script.py 0.00% <0.00%> (-91.75%) ⬇️
python/graphscope/deploy/kubernetes/utils.py 11.90% <0.00%> (-58.58%) ⬇️
python/graphscope/deploy/kubernetes/cluster.py 23.55% <0.00%> (-50.20%) ⬇️
...thon/graphscope/tests/kubernetes/test_with_mars.py 0.00% <0.00%> (-44.83%) ⬇️
python/graphscope/interactive/query.py 41.12% <0.00%> (-38.71%) ⬇️
...n/graphscope/deploy/kubernetes/resource_builder.py 30.59% <0.00%> (-25.95%) ⬇️
python/graphscope/client/rpc.py 80.55% <0.00%> (-12.04%) ⬇️
python/graphscope/client/session.py 67.86% <0.00%> (-7.19%) ⬇️
python/graphscope/framework/dag_utils.py 57.46% <0.00%> (-6.04%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa8649...f06e007. Read the comment docs.

@sighingnow sighingnow merged commit 23b612b into alibaba:main Apr 24, 2022
@sighingnow sighingnow deleted the ht/delete-append-only-frag branch April 24, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants