add ci tests for ir on vineyard #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1515 +/- ##
===========================================
- Coverage 73.61% 40.61% -33.01%
===========================================
Files 88 88
Lines 9681 9681
===========================================
- Hits 7127 3932 -3195
- Misses 2554 5749 +3195
Continue to review full report at Codecov.
|
sighingnow
approved these changes
May 7, 2022
lidongze0629
approved these changes
May 7, 2022
yecol
reviewed
May 7, 2022
| @@ -65,6 +65,11 @@ jobs: | |||
| cd ${GITHUB_WORKSPACE}/research/query_service/ir/compiler | |||
| make build | |||
|
|
|||
| - name: Build Ir on Vineyard Store | |||
| run: | | |||
| source ${HOME}/.bashrc | |||
There was a problem hiding this comment.
Why do we need to source this bashrc? It is user's customed envs.
If you have envs, should put them together into the .graphscope_env
There was a problem hiding this comment.
I'm not sure why, but we do have many source ~/.bashrc lines across all CI yamls. It might be used for leveraging local build cache or something like that, I guess.
yecol
reviewed
May 7, 2022
| @@ -86,3 +91,9 @@ jobs: | |||
| source ${HOME}/.bashrc | |||
| cd ${GITHUB_WORKSPACE}/interactive_engine/ir-adaptor && ./ir_groot_ci.sh | |||
|
|
|||
| - name: Ir Integration Test on Vineyard Store | |||
| run: | | |||
| source ${HOME}/.bashrc | |||
siyuan0322
approved these changes
May 10, 2022
yecol
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue number
Fixes