-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up include headers of analytical engine #1546
Conversation
98260eb
to
acff41b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bl::
-> boost::leaf
?
Codecov Report
@@ Coverage Diff @@
## main #1546 +/- ##
==========================================
- Coverage 73.17% 71.51% -1.66%
==========================================
Files 88 88
Lines 9714 9714
==========================================
- Hits 7108 6947 -161
- Misses 2606 2767 +161
Continue to review full report at Codecov.
|
The original |
One of the solutions to this is defining the |
Could you also report the effectiveness of this PR to speed up the building stage? |
a0aa9de
to
b746652
Compare
@@ -13,18 +13,41 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
#include <glog/logging.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why glog is so special, I noticed that it is in the top of the headers in many files, while gflags (I think they are similar libraries) remains in the way down.
b746652
to
8e457f9
Compare
pass compile update format Update
97c35a9
to
1c494e4
Compare
1c494e4
to
63046c3
Compare
What do these changes do?
core/config.h
, put to where leaf been usedmake
and remove gs_proto building time)Related issue number
Fixes #1541