Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix networkx.cnli forward and reorg forward algorithm tests #1584

Merged
merged 15 commits into from
May 23, 2022

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented May 18, 2022

What do these changes do?

  • Add a update method to NodeDict to fix forward networkx.convert_node_labels_to_integers problem;
  • Reorg forward algorithm ci;

Related issue number

Fixes #1502

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1584 (c85d0fc) into main (33546c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1584   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files          88       88           
  Lines        9714     9714           
=======================================
  Hits         7108     7108           
  Misses       2606     2606           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33546c9...c85d0fc. Read the comment docs.

@acezen acezen changed the title [WIP] Revise nx.compat to improve the capability of reuse NetworkX code Revise nx.compat to improve the capability of reuse NetworkX code May 19, 2022
@acezen acezen changed the title Revise nx.compat to improve the capability of reuse NetworkX code Fix networkx.convert_node_labels_to_integers forward and reorg forward algorithm tests May 19, 2022
@acezen acezen marked this pull request as ready for review May 19, 2022 01:17
@acezen acezen changed the title Fix networkx.convert_node_labels_to_integers forward and reorg forward algorithm tests Fix networkx.cnli forward and reorg forward algorithm tests May 19, 2022
@acezen acezen merged commit b5fff86 into alibaba:main May 23, 2022
@acezen acezen deleted the acezen/nx_compat branch May 23, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NetworkX] Improve the capability of reuse NetworkX code of grapescope.nx
3 participants