Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable string oid type support for FFI wrapper for GIE. #1638

Merged
merged 1 commit into from
May 30, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

Add support for int64 oid and string oid at the same time in the FFI wrapper.

Related issue number

Fixes #1265 and related to #1509

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1638 (3c7c3d7) into main (87b5613) will decrease coverage by 32.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1638       +/-   ##
===========================================
- Coverage   73.18%   40.27%   -32.91%     
===========================================
  Files          89       89               
  Lines        9736     9736               
===========================================
- Hits         7125     3921     -3204     
- Misses       2611     5815     +3204     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.30%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.66%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.41%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b5613...3c7c3d7. Read the comment docs.

@sighingnow sighingnow merged commit 0a50ed1 into alibaba:main May 30, 2022
@sighingnow sighingnow deleted the ht/add-column-string-oid branch May 30, 2022 02:26
sighingnow added a commit that referenced this pull request Jun 4, 2022
The error is introduced in #1638.

Signed-off-by: Tao He <sighingnow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Interactive engine doesn't support graphs with string as OID.
2 participants