set snapshot as extra params to get graph data of correct version in groot #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid potential cyclice dependencies while using the library in pegasus.
…o tag_name in sink op
[IR Runtime] IR TagOpt for more compact structure in Runtime
[IR Runtime] Support EdgeExpandWithIntersection and Unfold Op in Runtime
Revert "[IR Core] Support Union of Intersection in IR-Core"
…ction Revert "[IR Runtime] Support EdgeExpandWithIntersection and Unfold Op in Runtime"
shirly121
changed the title
shirly121
changed the title
shirly121
changed the title
shirly121
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1666 +/- ##
===========================================
- Coverage 73.18% 40.32% -32.86%
===========================================
Files 89 89
Lines 9736 9736
===========================================
- Hits 7125 3926 -3199
- Misses 2611 5810 +3199
Continue to review full report at Codecov.
|
|
LGTM, a little question: does this PR pass the e2e tests by hand since our CI doesn't have tests for the snapshot? I mean, the correctness of the PR is checked manually, not only compiled and unittested. Or we can add a few tests that focus on the snapshot, if applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
compiler fetches the snapshot from groot storage and pass to runtime as extra params to get graph data of correct version
Related issue number
Fixes #1566