Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize source chain operator #152

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

siyuan0322
Copy link
Collaborator

Description

GIE scan all vertices unnecessarily for a simple query like g.V().has('label','id', xxx).out().
It should use primary key to find the exact vertex.

Relational Context

This bug was found in an experiment of an industrial paper, where some simple query cost too much time to execute.

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #152 (4d44172) into main (16a93ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files          50       50           
  Lines        4576     4576           
=======================================
  Hits         3595     3595           
  Misses        981      981           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a93ea...4d44172. Read the comment docs.

@siyuan0322 siyuan0322 merged commit 0c56ff0 into alibaba:main Feb 20, 2021
@siyuan0322 siyuan0322 deleted the zsy/fix-source-chain branch February 20, 2021 07:59
MeloYang05 pushed a commit to shirly121/GraphScope that referenced this pull request Oct 9, 2022
…intersection

Revert "[IR Runtime] Support EdgeExpandWithIntersection and Unfold Op in Runtime"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants