[IR Compiler] fix error when creating json file #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to /tmp instead of current to have access to
lidongze0629
approved these changes
Jun 21, 2022
longbinlai
reviewed
Jun 21, 2022
| @@ -46,9 +46,12 @@ | |||
| // represent ir plan as a chain of operators | |||
| public class IrPlan implements Closeable { | |||
| private static IrCoreLibrary irCoreLib = IrCoreLibrary.INSTANCE; | |||
| private static String PLAN_JSON_FILE = "plan.json"; | |||
| // write to '/tmp' which is accessible from common users | |||
| private static String JSON_PLAN_DIR = "/tmp"; | |||
There was a problem hiding this comment.
Can we obtain temporary folder from some environment variables. For example, Mac's temporary fold is not at "/tmp"
There was a problem hiding this comment.
I think /tmp is ok in macOS, which is a link to /private/tmp, Or maybe you can get the tmp directory by System.getProperty('java.io.tmpdir')
https://kodejava.org/how-do-i-get-operating-system-temporary-directory-folder/
package org.kodejava.lang;
public class TempDirExample {
public static void main(String[] args) {
// This is the property name for accessing OS temporary directory
// or folder.
String property = "java.io.tmpdir";
// Get the temporary directory and print it.
String tempDir = System.getProperty(property);
System.out.println("OS temporary directory is " + tempDir);
}
}
Codecov Report
@@ Coverage Diff @@
## main #1743 +/- ##
===========================================
- Coverage 73.23% 40.22% -33.01%
===========================================
Files 89 89
Lines 9764 9764
===========================================
- Hits 7151 3928 -3223
- Misses 2613 5836 +3223
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #1729