Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug about can not join current thread during graph unloading #177

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Fix bug about can not join current thread during graph unloading #177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de2d9a
Fix bug about can not join current thread during graph unloading
lidongze0629 Mar 4, 2021
1ce42cd
format code
lidongze0629 Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/graphscope/framework/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,13 @@ def unload(self):
self._interactive_instance_launching_thread is not None
and self._interactive_instance_launching_thread.is_alive()
):
self._interactive_instance_launching_thread.join()
# join raises a RuntimeError if an attempt is made to join the current thread.
# this exception occurs when a object collected by gc mechanism contains a running thread.
if (
threading.current_thread()
!= self._interactive_instance_launching_thread
):
self._interactive_instance_launching_thread.join()
self._close_interactive_instances()
except Exception as e:
logger.error("Failed to close interactive instances: %s" % e)
Expand Down