[GAIA-IR] Make v6d_ffi build as features in IR #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tao He <sighingnow@gmail.com>
sighingnow
approved these changes
Jun 29, 2022
Signed-off-by: Tao He <sighingnow@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1775 +/- ##
===========================================
- Coverage 76.13% 40.08% -36.05%
===========================================
Files 89 89
Lines 9798 9798
===========================================
- Hits 7460 3928 -3532
- Misses 2338 5870 +3532
Continue to review full report at Codecov.
|
BingqingLyu
added this to In progress
in GIE for production (0627-0729) - extended for two weeks
via automation
BingqingLyu
added
the
component:gaia
BingqingLyu
moved this from In progress
to Reviewer approved
in GIE for production (0627-0729) - extended for two weeks
BingqingLyu
moved this from Reviewer approved
to Done
in GIE for production (0627-0729) - extended for two weeks
BingqingLyu
removed this from Done
in GIE for production (0627-0729) - extended for two weeks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Make v6d_ffi build as features.
When compiling IR (e.g., on exp_store) with
cargo build, v6d_ffi is not needed and will not be compiled.If we do want to query with IR on vineyard, build IR with
cargo build --features with_v6d. BTW, on the case of starting query service on vineyard, v6d_ffi will be compiled as a default choice (i.e., ininteractive_engine/executor/gaia_runtime/Cargo.toml).Related issue number
Fixes #1772