[GIE] Reorganize executor package by incorporating GAIA into GIE #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1883 +/- ##
===========================================
+ Coverage 43.81% 64.80% +20.98%
===========================================
Files 89 89
Lines 9804 9804
===========================================
+ Hits 4296 6353 +2057
+ Misses 5508 3451 -2057
Continue to review full report at Codecov.
|
… and remove executor/runtime
Signed-off-by: Tao He <sighingnow@gmail.com>
BingqingLyu
changed the title
siyuan0322
approved these changes
Jul 28, 2022
.github/workflows/gaia.yml
Outdated
|
|
||
| - name: Build Ir on Groot Store | ||
| run: | | ||
| source ${HOME}/.bashrc | ||
| cd ${GITHUB_WORKSPACE}/interactive_engine | ||
| mvn clean install -DskipTests -Pv2 -Drust.compile.mode=debug --quiet | ||
| mvn clean install -DskipTests -Pv2 -Drust.compile.mode=release --quiet |
There was a problem hiding this comment.
Why change the mode to release.
I think it's ok to use debug mode in CI environment and it can speed up the compiling.
There was a problem hiding this comment.
debug mode can speed up compiling, but result in slow testing.
There was a problem hiding this comment.
So which one is faster? debug compile + run or release compile + run?
There was a problem hiding this comment.
seems like release compile + run is faster
BingqingLyu
added
component:gie
component:gaia
sighingnow
reviewed
Jul 29, 2022
… in gss.yml(on groot) and ci.yml(on vineyard)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Reorganize executor package by moving GAIA from the
researchdirectory intointeractive_engine, including reorganizing packages in a more reasonable way, removing unused packages, etc.Related issue number
#1677