Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl partial_eq for Property and fix gitignore #1908

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

waruto210
Copy link
Contributor

@waruto210 waruto210 commented Jul 31, 2022

What do these changes do?

impl partial_eq for Property and add deps for build tests and benches, then fix gitignore

Related issue number

#1530

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022

Codecov Report

Merging #1908 (f63e330) into main (eb45c58) will decrease coverage by 32.87%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1908       +/-   ##
===========================================
- Coverage   72.99%   40.11%   -32.88%     
===========================================
  Files          89       89               
  Lines        9804     9804               
===========================================
- Hits         7156     3933     -3223     
- Misses       2648     5871     +3223     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.30%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.66%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.57%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb45c58...f63e330. Read the comment docs.

@waruto210 waruto210 marked this pull request as ready for review August 1, 2022 04:38
@waruto210 waruto210 changed the title impl partial_eq for Property impl partial_eq for Property and fix gitignore Aug 1, 2022
@BingqingLyu BingqingLyu self-requested a review August 1, 2022 06:07
Copy link
Collaborator

@BingqingLyu BingqingLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BingqingLyu BingqingLyu merged commit 1591300 into alibaba:main Aug 1, 2022
@waruto210 waruto210 deleted the impl_property branch August 1, 2022 11:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants