[GraphProxy] Optimize LazyDetails #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BingqingLyu
changed the title
BingqingLyu
changed the title
longbinlai
reviewed
Aug 3, 2022
interactive_engine/executor/ir/graph_proxy/src/apis/graph/element/property.rs
Outdated
Show resolved
Hide resolved
longbinlai
reviewed
Aug 3, 2022
interactive_engine/executor/ir/graph_proxy/src/apis/graph/element/property.rs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1921 +/- ##
==========================================
+ Coverage 35.01% 40.10% +5.09%
==========================================
Files 89 89
Lines 9816 9816
==========================================
+ Hits 3437 3937 +500
+ Misses 6379 5879 -500
Continue to review full report at Codecov.
|
longbinlai
reviewed
Aug 4, 2022
interactive_engine/executor/ir/graph_proxy/src/apis/graph/element/property.rs
Show resolved
Hide resolved
longbinlai
reviewed
Aug 4, 2022
interactive_engine/executor/ir/graph_proxy/src/apis/graph/element/property.rs
Outdated
Show resolved
Hide resolved
iamdrq
pushed a commit
to iamdrq/GraphScope
that referenced
this pull request
Aug 4, 2022
* [ReadGraph] optimize LazyDetails on GraphScopeStore * [ReadGraph] optimize LazyDetails on ExpStore * [ReadGraph] add EmptyDetails * fix ci test * [EmptyDetails] refine the implementations * [ReadGraph] optimize LazyDetails on ExpStore * [CI Test] add ci tests for empty detail cases * refine DynDetails as a enum type * further remove DefaultDetails * refine and fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled.
Related issue number
Fixes #1923