Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ipc sender after former one removed #1950

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Conversation

lnfjpt
Copy link
Collaborator

@lnfjpt lnfjpt commented Aug 8, 2022

Related issue number

Fixes
#1885

@lnfjpt lnfjpt requested a review from longbinlai August 8, 2022 11:33
@longbinlai longbinlai requested a review from bmmcq August 9, 2022 03:08
@codecov-commenter
Copy link

Codecov Report

Merging #1950 (6601bcc) into main (1de7533) will decrease coverage by 3.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
- Coverage   43.90%   40.10%   -3.80%     
==========================================
  Files          89       89              
  Lines        9816     9816              
==========================================
- Hits         4310     3937     -373     
- Misses       5506     5879     +373     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/deploy/hosts/cluster.py 29.41% <0.00%> (-58.83%) ⬇️
python/graphscope/analytical/app/java_app.py 24.24% <0.00%> (-44.95%) ⬇️
python/graphscope/framework/utils.py 40.10% <0.00%> (-14.85%) ⬇️
python/graphscope/framework/app.py 69.95% <0.00%> (-10.33%) ⬇️
python/graphscope/framework/graph_schema.py 52.45% <0.00%> (-7.11%) ⬇️
python/graphscope/tests/conftest.py 48.21% <0.00%> (-4.65%) ⬇️
python/graphscope/client/rpc.py 86.11% <0.00%> (-3.71%) ⬇️
python/graphscope/client/session.py 63.75% <0.00%> (-3.22%) ⬇️
python/graphscope/analytical/udf/utils.py 36.17% <0.00%> (-3.20%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de7533...6601bcc. Read the comment docs.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnfjpt lnfjpt merged commit 3a2165d into alibaba:main Aug 11, 2022
@siyuan0322 siyuan0322 mentioned this pull request Aug 11, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants