Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a getaddrinfo resolvable hostname as the local hostname (will be used as the etcd endpoint further). #2006

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

As titled. On macOS the socket.gethostname() is not always resolvable by getaddrinfo().

Related issue number

n/a, we received the bug report from our end users.

…e used as the etcd endpoint further).

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2006 (fa5f583) into main (be07087) will decrease coverage by 8.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
- Coverage   73.12%   64.90%   -8.22%     
==========================================
  Files          89       89              
  Lines        9834     9834              
==========================================
- Hits         7191     6383     -808     
- Misses       2643     3451     +808     
Impacted Files Coverage Δ
...aphscope/tests/kubernetes/test_resource_builder.py 0.00% <0.00%> (-100.00%) ⬇️
...on/graphscope/tests/kubernetes/test_demo_script.py 0.00% <0.00%> (-91.75%) ⬇️
python/graphscope/deploy/kubernetes/utils.py 11.90% <0.00%> (-58.58%) ⬇️
python/graphscope/deploy/kubernetes/cluster.py 23.19% <0.00%> (-50.96%) ⬇️
python/graphscope/tests/unittest/test_java_app.py 49.33% <0.00%> (-50.67%) ⬇️
python/graphscope/analytical/app/java_app.py 24.24% <0.00%> (-44.95%) ⬇️
...thon/graphscope/tests/kubernetes/test_with_mars.py 0.00% <0.00%> (-44.83%) ⬇️
python/graphscope/interactive/query.py 41.12% <0.00%> (-38.71%) ⬇️
...n/graphscope/deploy/kubernetes/resource_builder.py 30.59% <0.00%> (-25.95%) ⬇️
python/graphscope/client/rpc.py 76.85% <0.00%> (-15.75%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be07087...fa5f583. Read the comment docs.

@sighingnow sighingnow merged commit 6dff1dc into alibaba:main Sep 5, 2022
@sighingnow sighingnow deleted the ht/gethostname branch September 5, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants