Fix GAE-Bug: Cannot compile GAE app if java not installed #2060
Conversation
zhanglei1949
force-pushed
the
fix-bug
branch
2 times, most recently
from
b193ff0
to
87cd338
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
=======================================
Coverage 44.06% 44.06%
=======================================
Files 89 89
Lines 9845 9845
=======================================
Hits 4338 4338
Misses 5507 5507 Continue to review full report at Codecov.
|
| find_package(JNI REQUIRED) | ||
| include_directories(SYSTEM ${JAVA_INCLUDE_PATH}) | ||
| include_directories(SYSTEM ${JAVA_INCLUDE_PATH2}) | ||
| endif() |
There was a problem hiding this comment.
Those two block seems duplicate.
coordinator/gscoordinator/utils.py
Outdated
| _java_executable, os.X_OK | ||
| ): | ||
| return False | ||
| return True |
There was a problem hiding this comment.
We already have such utility: https://github.com/alibaba/GraphScope/blob/main/python/graphscope/framework/utils.py#L189-L197
There was a problem hiding this comment.
This method should be deleted.
zhanglei1949
force-pushed
the
fix-bug
branch
2 times, most recently
from
f1cd4cc
to
7a5caef
Compare
| endif() | ||
|
|
||
| # include jni------------------------------------------------------------------ | ||
| if(ENABLE_JAVA_SDK) |
There was a problem hiding this comment.
Seems these two if(ENABLE_JAVA_SDK) branches could be merged?
zhanglei1949
force-pushed
the
fix-bug
branch
from
859c3ed
to
3e32be1
Compare
f fix try to fix f format format f remove method f
zhanglei1949
force-pushed
the
fix-bug
branch
from
3e32be1
to
c6d4f4d
Compare
What do these changes do?
Related issue number
#2053