[GAE-Java] Make GAE Java SDK version align with GraphScope #2077
Conversation
zhanglei1949
force-pushed
the
main
branch
3 times, most recently
from
e04e77f
to
4771a59
Compare
zhanglei1949
changed the title
zhanglei1949
changed the title
coordinator/gscoordinator/utils.py
Outdated
| GRAPE_PROCESSOR_JAR = os.path.join( | ||
| GRAPHSCOPE_HOME, "lib", "grape-runtime-0.16.0-shaded.jar" | ||
| ) | ||
| GRAPE_PROCESSOR_JAR = glob.glob(GRAPHSCOPE_HOME + "/lib/grape-runtime*.jar")[0] |
There was a problem hiding this comment.
This [0] seems dangerous...
Could you handle the exception incase the jar is not there? So we won't crash the coordinator.
There was a problem hiding this comment.
Thanks for the suggestion, I have changed to
ANALYTICAL_ENGINE_JAVA_RUNTIME_JAR = os.path.join(
ANALYTICAL_ENGINE_JAVA_HOME,
"lib",
"grape-runtime-{}-shaded.jar".format(__version__),
)where the __version__ is imported from version.py
coordinator/gscoordinator/utils.py
Outdated
|
|
||
| ANALYTICAL_ENGINE_JAVA_RUNTIME_JAR = glob.glob( | ||
| ANALYTICAL_ENGINE_JAVA_HOME + "/lib/grape-runtime*.jar" | ||
| )[0] |
coordinator/gscoordinator/utils.py
Outdated
| )[0] | ||
| ANALYTICAL_ENGINE_JAVA_GRAPHX_JAR = glob.glob( | ||
| ANALYTICAL_ENGINE_JAVA_HOME + "/lib/graphx-on-graphscope*.jar" | ||
| )[0] |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
=======================================
Coverage 72.89% 72.89%
=======================================
Files 89 89
Lines 9872 9872
=======================================
Hits 7196 7196
Misses 2676 2676 Continue to review full report at Codecov.
|
What do these changes do?
Related issue number
Make GAE Java SDK version not fixed in code/configuration. BUT we still need to change
analytical_engine/java/pom.xmlfor GraphScope version change.