Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the correctness of retry (in the RunStep request) to avoid the strange "has no attribute" error #2094

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Ensure the correctness of retry (in the RunStep request) to avoid the strange "has no attribute" error #2094

merged 1 commit into from
Sep 28, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

  • Don't reuse the "generator" during retry
  • Some operation shouldn't be retried

Related issue number

Fixes #2093

@sighingnow
Ensure the correctness of retry (in the RunStep request)
f26481c 
Signed-off-by: Tao He <sighingnow@gmail.com>
@sighingnow sighingnow mentioned this pull request Sep 28, 2022
Closed
@sighingnow sighingnow merged commit 12f32ff into alibaba:main Sep 28, 2022
@sighingnow sighingnow deleted the ht/node-selector branch September 28, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siyuan0322 siyuan0322 siyuan0322 approved these changes

@lidongze0629 lidongze0629 Awaiting requested review from lidongze0629

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] AttributeError: 'list' object has no attribute 'add_vertices'
2 participants
@sighingnow @siyuan0322