Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App now can carry cmake options, and enabled wcc on string oid. #2130

Merged
merged 5 commits into from
Oct 12, 2022

Conversation

siyuan0322
Copy link
Collaborator

And fixed errors in precompile step.
https://github.com/alibaba/GraphScope/actions/runs/3221735048/jobs/5270025612

WCC on string will use global ID as component ID.

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Seems there are still some temporary comment blocks.

k8s/precompile.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #2130 (e6d4d5f) into main (31829fd) will increase coverage by 28.97%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2130       +/-   ##
===========================================
+ Coverage   43.83%   72.80%   +28.97%     
===========================================
  Files          87       89        +2     
  Lines        9891     9941       +50     
===========================================
+ Hits         4336     7238     +2902     
+ Misses       5555     2703     -2852     
Impacted Files Coverage Δ
python/graphscope/client/session.py 73.99% <ø> (+7.79%) ⬆️
python/graphscope/analytical/app/wcc.py 100.00% <100.00%> (+30.00%) ⬆️
python/graphscope/framework/app.py 92.16% <100.00%> (+11.88%) ⬆️
python/graphscope/framework/dag_utils.py 64.14% <100.00%> (+19.81%) ⬆️
python/graphscope/tests/unittest/test_app.py 95.71% <100.00%> (+95.71%) ⬆️
python/graphscope/version.py 100.00% <0.00%> (ø)
python/graphscope/__init__.py 82.14% <0.00%> (ø)
python/graphscope/framework/dag.py 81.63% <0.00%> (+1.02%) ⬆️
python/graphscope/client/rpc.py 92.59% <0.00%> (+2.77%) ⬆️
python/graphscope/client/utils.py 85.45% <0.00%> (+3.63%) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31829fd...e6d4d5f. Read the comment docs.

@sighingnow sighingnow merged commit 950ed7a into alibaba:main Oct 12, 2022
@siyuan0322 siyuan0322 deleted the zsy/wcc branch October 12, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants