Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAE-Java] Fix log4j jar missing in grape-runtime and java pie driver app's message strategy settable. #2140

Merged
merged 10 commits into from Oct 18, 2022

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Oct 17, 2022

What do these changes do?

Related issue number

Fixes

  • Add runtime log4j jar in grape-runtime.
  • Add message strategy variable in java driver app's template.

@zhanglei1949 zhanglei1949 marked this pull request as draft October 17, 2022 07:22
@sighingnow
Copy link
Collaborator

sighingnow commented Oct 17, 2022

Most of change in this pull request seems have nothing to do with the title (as well as description) of this pull request "Fix grape-runtime logging" ..

@zhanglei1949 zhanglei1949 changed the title [GAE-Java] Fix grape-runtime logging [GAE-Java] Fix log4j jar missing in grape-runtime and java pie driver app's message strategy settable. Oct 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Merging #2140 (3d9f66f) into main (7d351a2) will increase coverage by 27.39%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2140       +/-   ##
===========================================
+ Coverage   43.86%   71.26%   +27.39%     
===========================================
  Files          87       89        +2     
  Lines        9904     9941       +37     
===========================================
+ Hits         4344     7084     +2740     
+ Misses       5560     2857     -2703     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 49.33% <0.00%> (-50.67%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-44.68%) ⬇️
python/graphscope/client/rpc.py 88.88% <0.00%> (-0.93%) ⬇️
python/graphscope/version.py 100.00% <0.00%> (ø)
python/graphscope/__init__.py 82.14% <0.00%> (ø)
python/graphscope/framework/dag.py 81.63% <0.00%> (+1.02%) ⬆️
python/graphscope/client/utils.py 85.45% <0.00%> (+3.63%) ⬆️
python/graphscope/framework/graph_schema.py 64.61% <0.00%> (+5.25%) ⬆️
python/graphscope/client/session.py 72.42% <0.00%> (+6.28%) ⬆️
python/graphscope/framework/app.py 90.32% <0.00%> (+9.67%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d351a2...3d9f66f. Read the comment docs.

@@ -24,6 +24,7 @@

<artifactId>graphx-on-graphscope</artifactId>
<packaging>jar</packaging>
<name>Graphx on GraphScope</name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphx to GraphX.

GraphScope failover mechanism: 1008~1130 automation moved this from In progress to Reviewer approved Oct 18, 2022
@zhanglei1949 zhanglei1949 merged commit 77b4ec5 into alibaba:main Oct 18, 2022
GraphScope failover mechanism: 1008~1130 automation moved this from Reviewer approved to Done Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants