Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAE-Java] Fix : can not compile the submodule of GAE Java SDK #2146

Merged
merged 6 commits into from Oct 19, 2022

Conversation

zhanglei1949
Copy link
Collaborator

What do these changes do?

Related issue number

Fixes

Fix the problem that user can not compile only the submodule of GAE Java SDK

@zhanglei1949
Copy link
Collaborator Author

@lidongze0629 Maybe you need to replace 0.18.0 to the new version when release new version of GraphScope, =。=

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #2146 (9297940) into main (3220a7f) will decrease coverage by 1.57%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
- Coverage   66.30%   64.72%   -1.58%     
==========================================
  Files          89       89              
  Lines        9948     9948              
==========================================
- Hits         6596     6439     -157     
- Misses       3352     3509     +157     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 53.65% <0.00%> (-46.35%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-44.68%) ⬇️
python/graphscope/client/rpc.py 76.85% <0.00%> (-3.71%) ⬇️
python/graphscope/framework/graph_utils.py 80.15% <0.00%> (-2.39%) ⬇️
python/graphscope/deploy/hosts/cluster.py 85.88% <0.00%> (-2.36%) ⬇️
python/graphscope/framework/app.py 90.32% <0.00%> (-1.85%) ⬇️
python/graphscope/client/session.py 65.09% <0.00%> (-1.58%) ⬇️
python/graphscope/framework/utils.py 64.84% <0.00%> (-1.05%) ⬇️
python/graphscope/tests/conftest.py 76.27% <0.00%> (-0.34%) ⬇️
python/graphscope/framework/graph_schema.py 64.61% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3220a7f...9297940. Read the comment docs.

@yecol
Copy link
Collaborator

yecol commented Oct 19, 2022

@lidongze0629 Maybe you need to replace 0.18.0 to the new version when release new version of GraphScope, =。=

It would be hard to maintain the GraphScope version number in the pom file manually.
We have a file in the root named VERSION records the current version. Could you get the version from there?

Copy link
Collaborator

@yecol yecol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not assign a version manually.

@zhanglei1949
Copy link
Collaborator Author

@lidongze0629 Maybe you need to replace 0.18.0 to the new version when release new version of GraphScope, =。=

It would be hard to maintain the GraphScope version number in the pom file manually. We have a file in the root named VERSION records the current version. Could you get the version from there?

I'm not sure whether read project version from file is possible for a maven project, any idea? @sighingnow

@zhanglei1949
Copy link
Collaborator Author

  • For Source code release, replace <revision>0.18.0</revision> to a new version
  • For package building and release, the output jars of grape-jdk from make gae will use the version specified in VERSION

@zhanglei1949 zhanglei1949 merged commit 0c5a4b5 into alibaba:main Oct 19, 2022
@zhanglei1949 zhanglei1949 added this to In progress in GraphScope failover mechanism: 1008~1130 via automation Oct 20, 2022
@zhanglei1949 zhanglei1949 moved this from In progress to Reviewer approved in GraphScope failover mechanism: 1008~1130 Oct 21, 2022
@zhanglei1949 zhanglei1949 moved this from Reviewer approved to Done in GraphScope failover mechanism: 1008~1130 Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants