Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAE-Java] Speed up Java App runtime codegen& compiling #2150

Merged
merged 12 commits into from Oct 21, 2022

Conversation

zhanglei1949
Copy link
Collaborator

What do these changes do?

Related issue number

Fixes #2149

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #2150 (4cd2351) into main (733fda3) will increase coverage by 32.45%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2150       +/-   ##
===========================================
+ Coverage   40.03%   72.48%   +32.45%     
===========================================
  Files          87       89        +2     
  Lines        9911     9949       +38     
===========================================
+ Hits         3968     7212     +3244     
+ Misses       5943     2737     -3206     
Impacted Files Coverage Δ
python/graphscope/framework/app.py 91.70% <66.66%> (+21.19%) ⬆️
python/graphscope/tests/unittest/test_java_app.py 100.00% <100.00%> (+100.00%) ⬆️
python/graphscope/__init__.py 82.14% <0.00%> (ø)
python/graphscope/version.py 100.00% <0.00%> (ø)
python/graphscope/deploy/kubernetes/utils.py 70.47% <0.00%> (+0.95%) ⬆️
python/graphscope/framework/dag.py 81.63% <0.00%> (+1.02%) ⬆️
python/graphscope/client/utils.py 85.45% <0.00%> (+3.63%) ⬆️
python/graphscope/client/rpc.py 92.59% <0.00%> (+6.48%) ⬆️
python/graphscope/framework/operation.py 87.67% <0.00%> (+10.95%) ⬆️
python/graphscope/client/session.py 73.99% <0.00%> (+11.16%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733fda3...4cd2351. Read the comment docs.

@zhanglei1949 zhanglei1949 marked this pull request as ready for review October 19, 2022 12:13
author 霄磊 <xiaolei.zl@alibaba-inc.com> 1666086665 +0800
committer 霄磊 <xiaolei.zl@alibaba-inc.com> 1666176751 +0800

refactor GraphScopeAnnotationProcessor

Add pytest-timeout to requirements-dev.txt and fixes a deprecated warnings when running tests (alibaba#2145)

* Add pytest-timeout to requirements-dev.txt
* Filter out the deprecated warnings in compat.py

Signed-off-by: Tao He <sighingnow@gmail.com>

Rename pegasus.hosts to network.servers for executor (alibaba#2147)

refactor GraphScopeAnnotationProcessor

able to generate

add file as entrance

rename

dev

codegen ok, shell script not finished

remove script

format

format

fix : can not compile submodule

fix

fix : can not compile submodule

fix

f

revision

grape jdk can be built to new version by specifying -Drevision=NEW_VERSION

fix

fix

get vertex data from java class
GraphScope failover mechanism: 1008~1130 automation moved this from In progress to Reviewer approved Oct 20, 2022
@sighingnow
Copy link
Collaborator

How much speed up of building java apps can we expect after this pull request?

@zhanglei1949
Copy link
Collaborator Author

How much speed up of building java apps can we expect after this pull request?

About 2 times speeds up. With this PR merged , we can reduce the cost time of Java Python test from 25-30min to around 10min.

@zhanglei1949 zhanglei1949 merged commit 37fa85a into alibaba:main Oct 21, 2022
GraphScope failover mechanism: 1008~1130 automation moved this from Reviewer approved to Done Oct 21, 2022
@zhanglei1949 zhanglei1949 deleted the app-scanner branch November 3, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Performance] Running Java app takes too long
3 participants