Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create interactive engine failure on helm installed graphscope #2171

Merged
merged 1 commit into from Oct 26, 2022

Conversation

siyuan0322
Copy link
Collaborator

In helm installed cluster the names of coordinator and coordinator service are prefixed by instance id, whereas in python launched cluster the names are suffixed by instance id.

Reported by #2161

@codecov-commenter
Copy link

Codecov Report

Merging #2171 (2b8ac10) into main (89a4a21) will decrease coverage by 32.90%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2171       +/-   ##
===========================================
- Coverage   72.91%   40.01%   -32.91%     
===========================================
  Files          89       87        -2     
  Lines        9789     9752       -37     
===========================================
- Hits         7138     3902     -3236     
- Misses       2651     5850     +3199     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.19%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.00%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.72%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.47%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a4a21...2b8ac10. Read the comment docs.

@sighingnow sighingnow merged commit 2821169 into alibaba:main Oct 26, 2022
@siyuan0322 siyuan0322 deleted the zsy/helm branch October 26, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants