Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAE-Java] Remove String-specialized FFI classes and Simplify Java MessageManager interface #2195

Merged
merged 4 commits into from Nov 4, 2022

Conversation

zhanglei1949
Copy link
Collaborator

Fix issues #2194 #2189

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #2195 (02ffa79) into main (5a4312d) will increase coverage by 27.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2195       +/-   ##
===========================================
+ Coverage   40.03%   67.09%   +27.06%     
===========================================
  Files          87       89        +2     
  Lines        9752     9789       +37     
===========================================
+ Hits         3904     6568     +2664     
+ Misses       5848     3221     -2627     
Impacted Files Coverage Δ
...aphscope/tests/kubernetes/test_resource_builder.py 0.00% <0.00%> (-100.00%) ⬇️
...on/graphscope/tests/kubernetes/test_demo_script.py 0.00% <0.00%> (-91.75%) ⬇️
python/graphscope/deploy/kubernetes/utils.py 11.90% <0.00%> (-58.58%) ⬇️
python/graphscope/deploy/kubernetes/cluster.py 23.01% <0.00%> (-51.70%) ⬇️
...thon/graphscope/tests/kubernetes/test_with_mars.py 0.00% <0.00%> (-44.83%) ⬇️
...n/graphscope/deploy/kubernetes/resource_builder.py 30.52% <0.00%> (-26.32%) ⬇️
python/graphscope/interactive/query.py 71.95% <0.00%> (-17.08%) ⬇️
python/graphscope/client/rpc.py 77.09% <0.00%> (ø)
python/graphscope/__init__.py 82.14% <0.00%> (ø)
python/graphscope/version.py 100.00% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4312d...02ffa79. Read the comment docs.

fix

add string test in cmakelist

f

f

f

try to fix

f

f

f

fix test

f

f

f

f

s

f

f

f

debug

s

f

f

f

f

format

format

f

format

s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants