-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix]Update the DefaultTag to .Chart.AppVersion #2210
Conversation
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@@ -75,7 +75,7 @@ Return the proper graphscope-store image name | |||
|
|||
{{/* | |||
Return the proper image name | |||
{{ include "graphscope-store.images.image" ( dict "imageRoot" .Values.path.to.the.image "global" $ "DefaultTag" .Chart.AppVersion ) }} | |||
{{ include "graphscope-store.images.image" ( dict "imageRoot" .Values.path.to.the.image "global" $ "DefaultTag" .DefaultTag ) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete the "DefaultTag" . DefaultTag
as you won't use imageRoot.DefaultTag
anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DefaultTag
is a new KV parameter pointing to .Chart.AppVersion
and is used in the next logic.
0.18.0 is not released yet. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
===========================================
- Coverage 71.71% 40.02% -31.69%
===========================================
Files 89 87 -2
Lines 9793 9756 -37
===========================================
- Hits 7023 3905 -3118
- Misses 2770 5851 +3081
Continue to review full report at Codecov.
|
Thanks for @siyuan0322 , #2205 doesn't use the
.Chart.AppVersion
.I have tested it with the pr and works as expected.
BTW, it looks like the image
registry.cn-hongkong.aliyuncs.com/graphscope/graphscope-store:0.18.0
doesn't exist. Is there something I missed?/cc @sighingnow @siyuan0322