Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation error of graphx runner #2228

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

siyuan0322
Copy link
Collaborator

Fix an include error under gcc 10.2.1

[ 94%] Building CXX object CMakeFiles/graphx_runner.dir/core/java/javasdk.cc.o
In file included from /home/graphscope/graphscope/analytical_engine/core/java/graphx_runner.cc:15:
/home/graphscope/graphscope/analytical_engine/core/java/graphx_runner.h:46:15: error: expected constructor, destructor, or type co
nversion before ‘(’ token
   46 | DECLARE_string(task);
      |               ^
/home/graphscope/graphscope/analytical_engine/core/java/graphx_runner.h:47:15: error: expected constructor, destructor, or type co
nversion before ‘(’ token
   47 | DECLARE_string(ipc_socket);

@codecov-commenter
Copy link

Codecov Report

Merging #2228 (10142c0) into main (a11b453) will increase coverage by 32.97%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2228       +/-   ##
===========================================
+ Coverage   40.19%   73.16%   +32.97%     
===========================================
  Files          87       89        +2     
  Lines        9847     9884       +37     
===========================================
+ Hits         3958     7232     +3274     
+ Misses       5889     2652     -3237     
Impacted Files Coverage Δ
python/graphscope/version.py 100.00% <0.00%> (ø)
python/graphscope/__init__.py 82.14% <0.00%> (ø)
python/graphscope/framework/dag.py 81.63% <0.00%> (+1.02%) ⬆️
python/graphscope/client/utils.py 86.66% <0.00%> (+3.63%) ⬆️
python/graphscope/client/rpc.py 86.25% <0.00%> (+9.16%) ⬆️
python/graphscope/framework/operation.py 87.67% <0.00%> (+10.95%) ⬆️
python/graphscope/client/session.py 76.47% <0.00%> (+11.76%) ⬆️
python/graphscope/framework/graph_schema.py 64.84% <0.00%> (+12.10%) ⬆️
python/graphscope/analytical/app/bfs.py 100.00% <0.00%> (+12.50%) ⬆️
python/graphscope/framework/errors.py 93.65% <0.00%> (+14.28%) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11b453...10142c0. Read the comment docs.

@sighingnow sighingnow merged commit b4d7038 into alibaba:main Nov 22, 2022
@siyuan0322 siyuan0322 deleted the zsy/graphx branch November 22, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants