Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grape-demo shaded dependencies issue #2229

Merged
merged 2 commits into from Dec 14, 2022

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Nov 22, 2022

What do these changes do?

Related issue number

Fixes #2220

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #2229 (49cfcd5) into main (3f96376) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2229   +/-   ##
=======================================
  Coverage   72.87%   72.87%           
=======================================
  Files          89       89           
  Lines        9956     9956           
=======================================
  Hits         7255     7255           
  Misses       2701     2701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f96376...49cfcd5. Read the comment docs.

@sighingnow
Copy link
Collaborator

Remember removing "[WIP]" in the PR title before merging.

@zhanglei1949 zhanglei1949 changed the title [WIP] Fix grape-demo shaded dependencies issue Fix grape-demo shaded dependencies issue Dec 14, 2022
@zhanglei1949 zhanglei1949 merged commit 11c1715 into alibaba:main Dec 14, 2022
@zhanglei1949 zhanglei1949 deleted the scala-dep-fix branch May 8, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] analytical_engine : grape-demo run error for incompatible scala version.
4 participants