Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize for Makefiles and dockerfiles #2246

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Conversation

siyuan0322
Copy link
Collaborator

What do these changes do?

This PR reorganized Makefiles and dockerfiles, targets for the consistency of image and non-image version and ease of management.

Some major changes includes:

  • Redesigned the directory strucure under k8s, make similar targets appears in the same directory.
    • Some internal stuffs, which very unlikely would be used and be cared about by users, such as building wheels, building dataset image go to the internal directory
    • All dockerfiles go to the dockerfiles directory
    • Building scripts go to the build_scripts directory
    • All other scripts go to the utils directory
    • Add documentation.
  • Unified the make targets in root directory and k8s directory. Ideally, the only difference should be that one would produce local artifacts and the other would produce the image.
  • Drop unnecessary make targets - push, clean
  • Drop registry fields in developing stage for better readability
  • Disable the release of nightly jupyter, dataset and graphscope-store image, it's not yet necessary.

Related issue number

Fixes N/A

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #2246 (b0e1772) into main (f77627d) will decrease coverage by 1.20%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2246      +/-   ##
==========================================
- Coverage   73.00%   71.80%   -1.21%     
==========================================
  Files          89       89              
  Lines        9922     9922              
==========================================
- Hits         7244     7124     -120     
- Misses       2678     2798     +120     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 53.01% <0.00%> (-46.99%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-27.92%) ⬇️
python/graphscope/client/rpc.py 81.67% <0.00%> (-3.06%) ⬇️
python/graphscope/framework/graph_utils.py 80.15% <0.00%> (-2.39%) ⬇️
python/graphscope/client/session.py 75.09% <0.00%> (-1.53%) ⬇️
python/graphscope/framework/app.py 90.32% <0.00%> (-1.39%) ⬇️
python/graphscope/framework/utils.py 67.25% <0.00%> (-1.00%) ⬇️
python/graphscope/framework/graph_schema.py 64.61% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77627d...b0e1772. Read the comment docs.

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there still are many temporay comments, you may need to do a cleanup before merging.

@siyuan0322
Copy link
Collaborator Author

Looks like there still are many temporary comments, you may need to do a cleanup before merging

Do you mean those in CI yamls?

@siyuan0322 siyuan0322 merged commit 71d61e3 into alibaba:main Nov 28, 2022
@sighingnow
Copy link
Collaborator

Looks like there still are many temporary comments, you may need to do a cleanup before merging

Do you mean those in CI yamls?

Yes.

@siyuan0322 siyuan0322 deleted the zsy/reorg branch November 28, 2022 05:30
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022

😭 Deploy PR Preview 71d61e3 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants