-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize for Makefiles and dockerfiles #2246
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
==========================================
- Coverage 73.00% 71.80% -1.21%
==========================================
Files 89 89
Lines 9922 9922
==========================================
- Hits 7244 7124 -120
- Misses 2678 2798 +120
Continue to review full report at Codecov.
|
10b4bc9
to
bfed594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there still are many temporay comments, you may need to do a cleanup before merging.
Do you mean those in CI yamls? |
Yes. |
😭 Deploy PR Preview 71d61e3 failed. Build logs 🤖 By surge-preview |
What do these changes do?
This PR reorganized Makefiles and dockerfiles, targets for the consistency of image and non-image version and ease of management.
Some major changes includes:
k8s
, make similar targets appears in the same directory.internal
directorydockerfiles
directorybuild_scripts
directoryutils
directoryRelated issue number
Fixes N/A