Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure reconnect behaves as expected #2297

Merged
merged 2 commits into from Dec 6, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

as titled.

Related issue number

N/A

Signed-off-by: Tao He <sighingnow@gmail.com>
Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

pod_name_list,
) = self._grpc_client.create_analytical_instance()
self._pod_name_list = list(pod_name_list)
else:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This else seems redundant

Signed-off-by: Tao He <sighingnow@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #2297 (9046c15) into main (1e9fff4) will decrease coverage by 1.20%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
- Coverage   73.00%   71.80%   -1.21%     
==========================================
  Files          89       89              
  Lines        9922     9924       +2     
==========================================
- Hits         7244     7126     -118     
- Misses       2678     2798     +120     
Impacted Files Coverage Δ
python/graphscope/client/rpc.py 81.67% <ø> (-3.06%) ⬇️
python/graphscope/client/session.py 75.18% <100.00%> (-1.43%) ⬇️
python/graphscope/tests/unittest/test_java_app.py 53.01% <0.00%> (-46.99%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-27.92%) ⬇️
python/graphscope/framework/graph_utils.py 80.15% <0.00%> (-2.39%) ⬇️
python/graphscope/framework/app.py 90.32% <0.00%> (-1.39%) ⬇️
python/graphscope/framework/utils.py 67.25% <0.00%> (-1.00%) ⬇️
python/graphscope/framework/graph_schema.py 64.61% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e9fff4...9046c15. Read the comment docs.

@sighingnow sighingnow merged commit a327910 into alibaba:main Dec 6, 2022
@sighingnow sighingnow deleted the ht/reconnect branch December 6, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants