Fix return type of cython combine #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siyuan0322
force-pushed
the
zsy/cython
branch
from
8b20a71
to
9f3e51c
Compare
sighingnow
approved these changes
Dec 7, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 89 89
Lines 9937 9937
=======================================
Hits 7252 7252
Misses 2685 2685 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem that the return type of
Combinefunction in cython app frame is fixed.Thanks @wuyueandrew for reporting the bug.