Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connect session logic and wait for gae ready #2326

Merged
merged 6 commits into from Dec 13, 2022

Conversation

siyuan0322
Copy link
Collaborator

@siyuan0322 siyuan0322 commented Dec 12, 2022

  • Wait for analytical engine ready instead of sleep
  • Fix the logic of reconnecting
  • Improved the helper template to reduce complexity
  • Add tests for helm installed graphscope

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #2326 (50f6f98) into main (f9c8698) will decrease coverage by 7.21%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2326      +/-   ##
==========================================
- Coverage   72.97%   65.76%   -7.22%     
==========================================
  Files          89       89              
  Lines        9937     9956      +19     
==========================================
- Hits         7252     6548     -704     
- Misses       2685     3408     +723     
Impacted Files Coverage Δ
...on/graphscope/tests/kubernetes/test_demo_script.py 0.00% <0.00%> (-92.38%) ⬇️
...aphscope/tests/kubernetes/test_resource_builder.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/deploy/kubernetes/utils.py 11.90% <0.00%> (-58.58%) ⬇️
python/graphscope/deploy/kubernetes/cluster.py 23.01% <0.00%> (-51.70%) ⬇️
python/graphscope/tests/unittest/test_java_app.py 53.01% <0.00%> (-46.99%) ⬇️
...thon/graphscope/tests/kubernetes/test_with_mars.py 0.00% <0.00%> (-44.83%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-27.92%) ⬇️
...n/graphscope/deploy/kubernetes/resource_builder.py 30.52% <0.00%> (-26.32%) ⬇️
python/graphscope/interactive/query.py 69.51% <0.00%> (-14.64%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c8698...50f6f98. Read the comment docs.

@sighingnow sighingnow merged commit 7a3c215 into alibaba:main Dec 13, 2022
@siyuan0322 siyuan0322 deleted the zsy/wait-for-gae-ready branch December 13, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants