[GAE-Java] Automatically load grape_jvm_opt when create jvm instances through JNI
#2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglei1949
commented
Dec 13, 2022
analytical_engine/core/java/utils.h
Outdated
| std::string exec(const char* cmd) { | ||
| std::array<char, 128> buffer; | ||
| std::string result; | ||
| std::unique_ptr<FILE, decltype(&pclose)> pipe(popen(cmd, "r"), pclose); |
There was a problem hiding this comment.
Any idea for better way to do this?
siyuan0322
approved these changes
Dec 13, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
+ Coverage 71.66% 72.87% +1.20%
==========================================
Files 89 89
Lines 9956 9956
==========================================
+ Hits 7135 7255 +120
+ Misses 2821 2701 -120
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, GAE Java requires
GRAPE_JVM_OPTSto create jvm instance, which shall be export to environment withsource ${GRAPHSCOPE_HOME}/conf/grape_jvm_opt.With this PR, the required env variable will be automatically loaded.
GRAPHSCOPE_HOMEto analytical engine instance.grape_jvm_optthroughGRAPHSCOPE_HOMEGRAPE_JVM_OPTSbefore creating jvm instance through JNI.Update SSSPContext.java, writing result to C++ vertex array, allow the python context getting the result.