Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pytest warnings and install necessary plugins #2338

Merged
merged 4 commits into from Dec 28, 2022

Conversation

siyuan0322
Copy link
Collaborator

@siyuan0322 siyuan0322 commented Dec 20, 2022

  • Install pytest-timeout plugin
  • Fix a numpy warning
  • Fix a pandas warning:
    • /home/runner/.local/lib/python3.8/site-packages/graphscope/tests/conftest.py:611: FutureWarning: The prefix argument has been deprecated and will be removed in a future version. Use a list comprehension on the column names in the future.

GraphDAGNode doesn't need unload self from engine, cause it's never load itself.
Instead, Graph will take care of the unload, and it has already.
Fixes #2349

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #2338 (07b4819) into main (4485e49) will decrease coverage by 0.79%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   73.10%   72.30%   -0.80%     
==========================================
  Files          88       88              
  Lines        9719     9711       -8     
==========================================
- Hits         7105     7022      -83     
- Misses       2614     2689      +75     
Impacted Files Coverage Δ
python/graphscope/framework/utils.py 67.25% <ø> (-1.63%) ⬇️
python/graphscope/tests/unittest/test_java_app.py 52.38% <0.00%> (-47.62%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-4.57%) ⬇️
python/graphscope/client/rpc.py 81.34% <0.00%> (-2.99%) ⬇️
python/graphscope/framework/graph_utils.py 80.15% <0.00%> (-2.39%) ⬇️
python/graphscope/client/session.py 75.37% <0.00%> (-1.51%) ⬇️
python/graphscope/framework/app.py 90.32% <0.00%> (-1.39%) ⬇️
python/graphscope/framework/graph_schema.py 64.61% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4485e49...07b4819. Read the comment docs.

@siyuan0322 siyuan0322 force-pushed the zsy/pytest branch 2 times, most recently from 386ea60 to 518221d Compare December 27, 2022 04:30
@sighingnow sighingnow merged commit b028dc2 into alibaba:main Dec 28, 2022
@siyuan0322 siyuan0322 deleted the zsy/pytest branch December 29, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CI Failure: Python unittest test_create_graph.py got stuck forever
3 participants