Fix GAE v6d test with arrow projected fragment #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighingnow
approved these changes
Dec 26, 2022
|
LGTM. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
=======================================
Coverage 43.59% 43.59%
=======================================
Files 88 88
Lines 9714 9714
=======================================
Hits 4235 4235
Misses 5479 5479 Continue to review full report at Codecov.
|
songqing
force-pushed
the
fix_gae_test
branch
from
85f273a
to
7a80ae3
Compare
|
@sighingnow help to approval the workflows, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The run_vy_app.cc contains multiple algorithm tests, and some of them are about ArrowProjectedFragment.
However, now all these algorithms use the same params with the Project(), that is "ProjectedFragmentType::Project(fragment, 0, 0, 0, 0)", the last param of this function is "e_prop_id".
For SSSP, we need edge data, and the e_prop_id is not 0(0 is the src id column), but 2, so, the result of SSSP is wrong, see the following pic.
Related issue number
Fixes
So, we need multiple ProjectedFragmentTypes with different node end edge types, and that's the PR does.